[PATCH] D79978: Call Frame Information (CFI) Handling for Basic Block Sections

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: llvm/lib/CodeGen/CFIInstrInserter.cpp:344
+          *MBBInfo.MBB, MBBI);
+      InsertedCFIInstr = true;
+    }
----------------
Should we add a continue here after setting PrevMBBInfo = &MBBInfo? We shouldn't insert any extra CSR related CFI directives based on prev MBB. 


================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:488-490
+  MachineFunction &MF = *MBB.getParent();
+  if (!hasFP(MF))
+    return;
----------------
.cfi_offset directive for framepointer is inserted after other .cfi_offset directives for callee save registers. This is different from the .cfi_offset order inserted for prologue. I am not familiar with how the dedup cfi is implemented. A question is will the order difference reduce the chance of deduplicating cfi in prologue?  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79978/new/

https://reviews.llvm.org/D79978