[PATCH] D83308: [Power10] Implement Vector Replace Builtins in LLVM

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM as long as the inheriting of GCCBuiltin is removed. This can be done on commit.



================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:526
+  // P10 Vector Insert with immediate.
+  def int_ppc_altivec_vinsw : GCCBuiltin<"__builtin_altivec_vinsw">,
+              Intrinsic<[llvm_v4i32_ty],
----------------
amyk wrote:
> If we are going to custom codegen the front end, I believe we have to omit the `GCCBuiltin` part. Same with `int_ppc_altivec_vinsd`. 
Yes. Even if we don't plan custom code gen in the front end, we shouldn't have this in the initial back end patch because it is referencing a builtin that we do not define.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83308/new/

https://reviews.llvm.org/D83308