[PATCH] D80951: [GlobalOpt] Remove preallocated calls when possible

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 05:55:40 PDT 2020


hans added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:2405
+    if (F->getAttributes().hasAttrSomewhere(Attribute::Preallocated) &&
+        !F->hasAddressTaken()) {
+      RemovePreallocated(F);
----------------
aeubanks wrote:
> efriedma wrote:
> > Do you also need to check for musttail calls?
> Good point, done
Actually, I think the old code is also missing that check :-) Sent  D83300


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80951/new/

https://reviews.llvm.org/D80951





More information about the llvm-commits mailing list