[PATCH] D83232: [llvm-readobj] - Don't abort when dumping dynamic relocations when an object has both REL and RELA.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 05:18:58 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with one suggestion.
================
Comment at: llvm/test/tools/llvm-readobj/ELF/broken-dynamic-reloc.test:499
+ Relocations:
+ - Type: R_X86_64_NONE
+ - Name: .dynamic
----------------
Consider specifying on offset for one of these relocations, to distinguish it from the other, and show that the same region isn't being read for both now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83232/new/
https://reviews.llvm.org/D83232
More information about the llvm-commits
mailing list