[PATCH] D83046: [LiveDebugValues] 1/4 Install an implementation-picking LiveDebugValues pass

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked 9 inline comments as done.
jmorse added a comment.

Thanks for the feedback,

In D83046#2135151 <https://reviews.llvm.org/D83046#2135151>, @djtodoro wrote:

> Instead of `git mv llvm/lib/CodeGen/LiveDebugValues.cpp llvm/lib/CodeGen/VarLocBasedImpl.cpp`
>  it should be as following:
>  `git mv llvm/lib/CodeGen/LiveDebugValues.cpp llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp`


Ah yep, missed that,

> I'd prefer adding all the patches in the stack, since there might be developers using some scripts for applying the patches automatically from Phabricator.

Sure, I'll upload that shortly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83046/new/

https://reviews.llvm.org/D83046