[PATCH] D83283: [Attributor] AAPotentialValues Interface

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added a comment.

Nit comments, I haven't yet digested the whole patch.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:3056
+  static inline APInt getEmptyKey() {
+    APInt V(nullptr, 0);
+    V.U.VAL = 0;
----------------
Is there an `APInt` constructor that takes a pointer and an `int` ? I think the only such constructor is a private one.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:3057
+    APInt V(nullptr, 0);
+    V.U.VAL = 0;
+    return V;
----------------
I also think that this `U` member is `private`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83283/new/

https://reviews.llvm.org/D83283