[PATCH] D83257: [SCCP] Handle assume predicates
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 02:39:10 PDT 2020
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:1337
IV, &CB,
ValueLatticeElement::getRange(NewCR, /*MayIncludeUndef=*/true));
return;
----------------
nikic wrote:
> We could set MayIncludeUndef=false for assumes (as undef/poison has always been UB there), but I didn't think it worthwhile to make the distinction, as we plan to flip this for branches in the future anyway.
It's probably not worth the trouble and we should just prioritize flipping the flag in general.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83257/new/
https://reviews.llvm.org/D83257
More information about the llvm-commits
mailing list