[PATCH] D83264: [ELF] Add -z dead-reloc-in-nonalloc=<section_glob>=<value>

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Aside from the inline comment, this looks reasonable, but I haven't looked in detail due to time constraints.



================
Comment at: lld/test/ELF/dead-reloc-in-nonalloc.s:32-33
+## If a section matches multiple patterns. The last pattern wins.
+# RUN: ld.lld --icf=all -z dead-reloc-in-nonalloc='.debug_i*=1' \
+# RUN:   -z dead-reloc-in-nonalloc='.debug_info=0' %t.o -o - | cmp %tzero -
+
----------------
I'd be slightly tempted to swap the two arguments around, to show that it is definitely last, and not most-specific, that wins.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83264/new/

https://reviews.llvm.org/D83264