[PATCH] D83282: [DWARFYAML] Refactor: Pull out member functions to DWARFYAMLUtils.cpp.

Tue Jul 7 01:40:27 PDT 2020

Higuoxing planned changes to this revision.
Higuoxing added a comment.

In D83282#2135231 <https://reviews.llvm.org/D83282#2135231>, @grimar wrote:

> So, currently, for example, `DWARFYAML::Data` is defined in `DWARFYAML.h`
>  (https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/ObjectYAML/DWARFYAML.h#L180) and implemented in `DWARFYAML.cpp`.
>
> With this change the implementation of members is moved to a new `DWARFYAMLUtils.cpp` file. I.e. we have `DWARFYAML.h` + `DWARFYAMLUtils.cpp` with this patch.
>  Honestly, it looks a bit unnatural to me, because it breaks the straightforward common approach: "define in a header, implement in a cpp with the same name".
>
> You're saying that "In the future, we will add some helper functions that make DWARF sections interlinked". Perhaps I'd wait for these functions to appear and may be
>  then create `DWARFYAMLUtils.h` + `DWARFYAMLUtils.cpp` for them.

Sure, I will upload them later to see how it works, thanks for the suggestion!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83282/new/

https://reviews.llvm.org/D83282