[PATCH] D83046: [LiveDebugValues] 1/4 Install an implementation-picking LiveDebugValues pass

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Instead of `git mv llvm/lib/CodeGen/LiveDebugValues.cpp llvm/lib/CodeGen/VarLocBasedImpl.cpp`
it should be as following:
`git mv llvm/lib/CodeGen/LiveDebugValues.cpp llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp`

> Plus moving the source file in CMakeLists.txt. I've assumed that such a file movement doesn't need reviewing; I can upload a review if anyone wants a closer look though.

I'd prefer adding all the patches in the stack, since there might be developers using some scripts for applying the patches automatically from Phabricator.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:1
+#include "llvm/CodeGen/MachineBasicBlock.h"
+#include "llvm/CodeGen/MachineFrameInfo.h"
----------------
Same as above.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:22
+
+#include "LiveDebugValues.h"
+
----------------
According to the LLVM coding standard, this should be included first.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.h:1
+#include "llvm/CodeGen/MachineFunction.h"
+#include "llvm/CodeGen/TargetPassConfig.h"
----------------
I think we are missing the file header at the beginning of the file.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.h:20
+
+  } // NS SharedLiveDebugValues
+
----------------
// namespace SharedLiveDebugValues


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.h:24
+  extern LDVImpl *makeVarLocBasedLiveDebugValues();
+} // NS llvm
----------------
// namespace llvm




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83046/new/

https://reviews.llvm.org/D83046