[PATCH] D83275: [llc] (almost) remove `--print-machineinstrs`

Mon Jul 6 21:36:56 PDT 2020

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

I was worried for a moment that we'd be losing the ability to print between all machine passes but it looks like -print-after-all covers that now (I don't think that was always the case). So long as we aren't losing any inter-pass dumps this LGTM but I'd suggest giving it a few days to see if anyone was using this in a way that isn't evident from the tests.

> -print-after/-stop-after since isel pass does not have commandline name.

IIRC, there's something weird going on in this area. I vaguely remember a problem I never got to the bottom of where there was no name when AMDGPU was omitted but when it was compiled, everybody's pass was called `amdgpu-isel`. It had something to do with AMDGPU needing additional dependencies and using INITIALIZE_PASS to get them.

================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:144

-static cl::opt<std::string> PrintMachineInstrs(
-    "print-machineinstrs", cl::ValueOptional, cl::desc("Print machine instrs"),
-    cl::value_desc("pass-name"), cl::init("option-unspecified"), cl::Hidden);
+// FIXME: remove this after switching to NPM. Currently there are two users:s
+//    llvm/test/CodeGen/AArch64/min-jump-table.ll
----------------
There's a typo (`:`->`'`) but also there's more tests affected than just the two. Probably best to keep the exact number vague

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83275/new/

https://reviews.llvm.org/D83275