[PATCH] D82673: [ModuloSchedule] Make PeelingModuloScheduleExpander inheritable.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D82673#2129786 <https://reviews.llvm.org/D82673#2129786>, @hgreving wrote:

> In short - the virtuality is not the issue, the inheritability is. The class can be non-virtual, no problem for us. I would like to reuse existing code in the upstream pass that is currently "private". Hence, the "protected" part is important. It also makes sense generally, because a software pipeliner on a specific subtarget may follow different expansion strategies. If you would like to revert the virtuality, no problem at all, if you keep the protected inheritance. I think we should design a better defined interface for this class in the long run. Only one target upstream and us downstream are using it AFAIK, but as we are supporting more targets, we may come up with something better. SG? Can pull in Hexagon people, yes


Ah, fair enough. Thanks for explaining!

I've removed the virtual dtor and virtuality from `expand` in 7a99aab8692c58558b62e9a66120886b8a70fab8 <https://reviews.llvm.org/rG7a99aab8692c58558b62e9a66120886b8a70fab8>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82673/new/

https://reviews.llvm.org/D82673