[llvm] 7a99aab - [ModuloSchedule] Devirtualize PeelingModuloScheduleExpander::expand as it's not needed

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 18:05:41 PDT 2020


Author: David Blaikie
Date: 2020-07-06T18:05:32-07:00
New Revision: 7a99aab8692c58558b62e9a66120886b8a70fab8

URL: https://github.com/llvm/llvm-project/commit/7a99aab8692c58558b62e9a66120886b8a70fab8
DIFF: https://github.com/llvm/llvm-project/commit/7a99aab8692c58558b62e9a66120886b8a70fab8.diff

LOG: [ModuloSchedule] Devirtualize PeelingModuloScheduleExpander::expand as it's not needed

The use case is out of tree code deriving from this class - but without
a need to use the base class polymorphically, so skip the virtualization
and virtual dtor.

Post-commit review from 50ac7ce94f34c5f43b02185ae0c33e150e78b044

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/ModuloSchedule.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/ModuloSchedule.h b/llvm/include/llvm/CodeGen/ModuloSchedule.h
index be0108dfa936..1aa23208cfb9 100644
--- a/llvm/include/llvm/CodeGen/ModuloSchedule.h
+++ b/llvm/include/llvm/CodeGen/ModuloSchedule.h
@@ -282,9 +282,8 @@ class PeelingModuloScheduleExpander {
                                 LiveIntervals *LIS)
       : Schedule(S), MF(MF), ST(MF.getSubtarget()), MRI(MF.getRegInfo()),
         TII(ST.getInstrInfo()), LIS(LIS) {}
-  virtual ~PeelingModuloScheduleExpander() {}
 
-  virtual void expand();
+  void expand();
 
   /// Runs ModuloScheduleExpander and treats it as a golden input to validate
   /// aspects of the code generated by PeelingModuloScheduleExpander.


        


More information about the llvm-commits mailing list