[PATCH] D83236: [DWARF] Add cutoff guarding validThroughout to avoid near-quadratic behaviour

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h:598
+      const DbgValueHistoryMap::Entries &Entries,
+      SmallPtrSetImpl<const MachineBasicBlock *> &VeryLargeBlocks);
 
----------------
Not very important, but: Assuming that `VeryLargeBlocks` will only be populated in the pathological case, micro-optimizing with a *Small*PtrSet seems unnecessary. Perhaps it's more memory-efficient on average to just use a DenseSet?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83236/new/

https://reviews.llvm.org/D83236