[PATCH] D78133: [PredicateInfo] Optionally set OriginalOp to renamed value it refers to.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D78133#2131838 <https://reviews.llvm.org/D78133#2131838>, @nikic wrote:

> Do we need to have this behind an option? That is, are there any PredicateInfo consumers who would //not// want this behavior?


Currently NewGVN relies on the current behavior. It uses it to easily look up the original instruction and uses it to merge the metadata of replacement instructions (which is not an issue for SCCP because we don't replace the predicates with other equivalent instructions which could have metadata). I guess we could try to keep track of the original instruction in NewGVN (or traverse the chain there), but I don't think it's worth blocking the patch on the change to NewGVN.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78133/new/

https://reviews.llvm.org/D78133