[PATCH] D82713: Improve stack object printing.

[Evandro Menezes via Phabricator via llvm-commits]

evandro added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFrameInfo.cpp:240
     if (i < NumFixedObjects)
-      OS << ", fixed";
+      OS << ", fixed:";
     if (i < NumFixedObjects || SO.SPOffset != -1) {
----------------
madhur13490 wrote:
> evandro wrote:
> > s/fixed:/fixed/
> As I said earlier, there is inconsistency; at some place "=" and other ":". It depends on personal choice but we need to agree on one. 
> 
Since the word `fixed` is followed by a comma, it should be followed by neither `:` nor `=`, as originally.


================
Comment at: llvm/test/CodeGen/AArch64/tailcall_misched_graph.ll:26
+; COMMON: Frame Objects:
+; COMMON:  fi#-4: {{.*}} fixed:, at location [SP+8], Split Slot: No
+; COMMON:  fi#-3: {{.*}} fixed:, at location [SP], Split Slot: No
----------------
E.g., `fixed` followed by `:` and `,` makes no sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82713/new/

https://reviews.llvm.org/D82713