[PATCH] D82580: [RegisterCoalescer] Dumper for JoinVals

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/CodeGen/RegisterCoalescer.cpp:2343
+      }
+      if (OtherVNI) O << " Other:", OtherVNI->print(O);
+      if (RedefVNI) O << " Redef:", RedefVNI->print(O);
----------------
Comma operator here is definitely weird. Braces and separate lines?


================
Comment at: llvm/lib/CodeGen/RegisterCoalescer.cpp:2344-2347
+      if (RedefVNI) O << " Redef:", RedefVNI->print(O);
+      if (ErasableImplicitDef) O << " ImpDef";
+      if (Pruned || PrunedComputed) O << ' ' << (Pruned ? "Pruned" : "NonPruned");
+      if (PrunedComputed) O << 'C';
----------------
Separate lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82580/new/

https://reviews.llvm.org/D82580