[PATCH] D83024: [PGO] Instrument function entry BB by default in IR PGO

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 13:24:15 PDT 2020


davidxl added a comment.

If we require profile-use also to use the option, it will work, but I think it is better and more convenient to change variant bit (I believe there are plenty). Bumping version can potentially complicate things in the future.

We should probably also add a new directive in text format for the variant, something like

:entry_first

When the directive is lacking, it means the old variant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83024/new/

https://reviews.llvm.org/D83024





More information about the llvm-commits mailing list