[PATCH] D83177: [llvm-reduce] Reducing call operand bundles

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 13:07:34 PDT 2020


lebedev.ri marked 3 inline comments as done.
lebedev.ri added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceOperandBundles.cpp:138
+
+  for_each(R.CallsToRefine, [](const auto &P) {
+    return maybeRewriteCallWithDifferentBundles(P.first, P.second);
----------------
Tyker wrote:
> Maybe we should make CallsToRefine a MapVector since the association from a index to a Bundle depends on its order in the map.
> and the key depends on a pointer value that will change when the Module gets cloned.
No, the current logic is correct, that map doesn't live that long.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83177/new/

https://reviews.llvm.org/D83177





More information about the llvm-commits mailing list