[PATCH] D83089: DomTree: Extract (mostly) read-only logic into type-erased base classes

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle updated this revision to Diff 275812.
nhaehnle marked an inline comment as done.
nhaehnle added a comment.

- rename generic_{begin,end,children} back without the generic_ prefix and refer explictly to base class methods in NewGVN, which wants to mutate the order of dominator tree node children directly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83089/new/

https://reviews.llvm.org/D83089

Files:
  llvm/include/llvm/CodeGen/MachineDominators.h
  llvm/include/llvm/Support/GenericDomTree.h
  llvm/include/llvm/Support/GenericDomTreeConstruction.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/GenericDomTree.cpp
  llvm/lib/Transforms/Scalar/ADCE.cpp
  llvm/lib/Transforms/Scalar/NewGVN.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83089.275812.patch
Type: text/x-patch
Size: 43287 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200706/33a382eb/attachment.bin>