[PATCH] D78861: [Attributor] [WIP] Track AA dependency using dependency graph

[Luofan Chen via Phabricator via llvm-commits]

bbn added a comment.

In D78861#2131573 <https://reviews.llvm.org/D78861#2131573>, @jdoerfert wrote:

> This looks pretty good :). Nice active review :)
>
> I have some minor comments below. We also should add a test for the print and dot output.


I need some help here:
Is there a way to test the dot output? I checked the .dot file and found it hard to write CHECK lines (see below) because we are interested in the link between different graph nodes (line 3 and line 4)

  	Node0x55be15e4f7d0 [shape=record,label="{[AAValueSimplify] for CtxI '  %2 = load i32, i32* %0, align 4' at position \{arg: [@0]\} with state simplified\n}"];
  	Node0x55be15e4f810 [shape=record,label="{[AANoUnwind] for CtxI '  %2 = load i32, i32* %0, align 4' at position \{fn:checkAndAdvance [checkAndAdvance at -1]\} with state nounwind\n}"];
  	Node0x55be15e4f810 -> Node0x55be15e500b0;
  	Node0x55be15e4f810 -> Node0x55be15e500b0;

I have referred to some other similar tests like the *cfg_deopt_unreach.ll`, but none of theme shows how to write check lines for such testcases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78861/new/

https://reviews.llvm.org/D78861