[PATCH] D83059: [RISCV] Use Generated Instruction Uncompresser

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:54:24 PDT 2020


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:148-152
+  bool Res;
+  MCInst UncompressedMI;
+  Res = uncompressInst(UncompressedMI, Inst, MRI, STI);
+  if (Res)
+    Inst = std::move(UncompressedMI);
----------------
Nit: declare `Res` at the point of initialization or, probably better yet, just do the `if` on the result of `uncompressInst`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83059/new/

https://reviews.llvm.org/D83059





More information about the llvm-commits mailing list