[PATCH] D83122: Fix crash when getVFABIMappings is called with an indirect call instruction

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:54:11 PDT 2020


fpetrogalli requested changes to this revision.
fpetrogalli added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/unittests/Analysis/VectorFunctionABITest.cpp:12
 #include "llvm/IR/InstIterator.h"
+#include "llvm/IRReader/IRReader.h"
 #include "gtest/gtest.h"
----------------
Is this needed?


================
Comment at: llvm/unittests/Analysis/VectorFunctionABITest.cpp:634
+  LLVMContext C;
+  std::unique_ptr<Module> M = parseIR(C, R"IR(
+define void @call(void () * %f) {
----------------
Very elegant, but is this `unique_ptr` needed? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83122/new/

https://reviews.llvm.org/D83122





More information about the llvm-commits mailing list