[PATCH] D83228: [llvm] [unittests] Remove some temporary files after they're not needed
Sergej Jaskiewicz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 6 12:54:05 PDT 2020
broadwaylamb created this revision.
broadwaylamb added reviewers: sammccall, chandlerc, thakis.
Herald added subscribers: llvm-commits, jfb, atanasyan, jrtc27, mgorny, sdardis.
Herald added a project: LLVM.
Some LLVM unit tests forget to clean up the temporary files and directories.
Use existing RAII classes for cleaning them up, remove duplicated code (`ScopedDir`, `ScopedFile`, `ScopedLink` classes) by extracting it into a common header file.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D83228
Files:
llvm/unittests/CMakeLists.txt
llvm/unittests/ProfileData/SampleProfTest.cpp
llvm/unittests/Support/FileCollectorTest.cpp
llvm/unittests/Support/FileUtilitiesTest.cpp
llvm/unittests/Support/TarWriterTest.cpp
llvm/unittests/Support/VirtualFileSystemTest.cpp
llvm/unittests/tools/llvm-exegesis/Mips/BenchmarkResultTest.cpp
llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp
llvm/utils/unittest/support/llvm-test-helper.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83228.275704.patch
Type: text/x-patch
Size: 13194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200706/484f6042/attachment-0001.bin>
More information about the llvm-commits
mailing list