[PATCH] D83034: [GlobalISel] Don't skip adding predicate matcher

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I would expect the existing tablegen tests to break from this and need updating?



================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3575
+      HasPredicateCode = true;
+      InsnMatcher.addPredicate<GenericInstructionPredicateMatcher>(Predicate);
+    }
----------------
I think this should remain as the last predicate type added to the matcher, after everything else here. The ordering does matter (see D82331)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83034/new/

https://reviews.llvm.org/D83034