[PATCH] D83225: [llvm-readobj] - Refactor the MipsGOTParser<ELFT> to stop using report_fatal_error().

[George Rimar via Phabricator via llvm-commits]

grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, atanasyan.
Herald added subscribers: rupprecht, arichardson, sdardis, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

`MipsGOTParser` is a helper class that is used to dump MIPS GOT and PLT.
There is a problem with it: it might call `report_fatal_error()` on invalid input.
When this happens, the tool reports a crash:

  # command stderr:
  LLVM ERROR: Cannot find PLTGOT dynamic table tag.
  PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backt
  race.
  Stack dump:
  ...

Such error were not tested. In this patch I've refactored `MipsGOTParser`:

I've splitted handling of GOT and PLT to separate methods. This allows to propagate
any possible errors to caller and should allow to dump the PLT when something is wrong
with the GOT and vise versa in the future.

I've added tests for each `report_fatal_error()`
and now calling the `reportError` instead. In the future we might want to switch to
reporting warnings, but it requres the additional testing and should
be performed independently.

I've kept `unwrapOrError` calls untouched for now as I'd like to focus on eliminating
`report_fatal_error` calls in this patch only (to stop crashing on invalid inputs
when doing inputs fuzzing).


https://reviews.llvm.org/D83225

Files:
  llvm/test/tools/llvm-readobj/ELF/mips-got.test
  llvm/test/tools/llvm-readobj/ELF/mips-plt.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83225.275700.patch
Type: text/x-patch
Size: 53073 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200706/af5ddb41/attachment-0001.bin>