[PATCH] D82995: [UpdateTestChecks] Allow $ in function names

[David Greene via Phabricator via llvm-commits]

greened marked an inline comment as done.
greened added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/asm.py:122
 
 ASM_FUNCTION_ARM_MACHO_RE = re.compile(
      r'^_(?P<func>[^:]+):[ \t]*\n'
----------------
spatel wrote:
> Do these ARM regexes not need the extra '?' like the others?
I'm not entirely certain.  `<func>` will match `"` because `[^:]` matches `"`.  I originally developed this against x86_64 and the way the asm printer works for that target, the function symbol itself is printed without quotes (`$` is fine in symnbol names) but the *comment* following the label includes the quotes.  I did the same for every other target though I should verify that is correct (I will add tests for every target).  Since these AArch64 patterns don't include a comment after the labels I didn't have anywhere to put quotes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82995/new/

https://reviews.llvm.org/D82995