[PATCH] D81939: [deadargelim] Attach dbg info to the insert/extractvalue instructions

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp:973
               // return value
               V = ExtractValueInst::Create(NewCB, NewRetIdxs[Ri], "newret",
                                            InsertPt);
----------------
vsk wrote:
> aprantl wrote:
> > @vsk: would it be better style to ad-hoc create an IRBuilder with the correct debug location here?
> Yes, that seems to be the common idiom. I recommend using `IRBuilder<NoFolder>` to avoid spurious test changes. 
Oh.. The `IRBuilder<>` will generate a debug loc by default (via `insert()` method).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81939/new/

https://reviews.llvm.org/D81939