[PATCH] D83002: [llvm-libtool-darwin] Add support for -static option

Sameer Arora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:41:25 PDT 2020


sameerarora101 marked an inline comment as done.
sameerarora101 added inline comments.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:85
+  std::vector<NewArchiveMember> NewMembers;
+  for (const StringRef &Member : InputFiles)
+    if (Error E = addMember(NewMembers, Member))
----------------
@jhenderson  Should I replace the type of `Member` back to `auto`. clang-tidy raises a warning with `StringRef`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83002/new/

https://reviews.llvm.org/D83002





More information about the llvm-commits mailing list