[PATCH] D83177: [llvm-reduce] Reducing call operand bundles
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 6 12:35:33 PDT 2020
lebedev.ri marked 2 inline comments as done.
lebedev.ri added inline comments.
================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceOperandBundles.cpp:34
+
+using namespace llvm;
+
----------------
nickdesaulniers wrote:
> lebedev.ri wrote:
> > nickdesaulniers wrote:
> > > if you move this up, then you don't need to wrap the forward declaration of `class Module` above.
> > Hold up, that's actually bogus.
> > https://godbolt.org/z/0qTwwz
> or just include the appropriate header for `llvm::Module` and forget forward declaration?
But here we don't need to know what `Module` actually is though, just a pointer to it.
The current include list is what IWYU suggests,
and i believe cleanup elsewhere in codebase is ongoing in the same direction.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83177/new/
https://reviews.llvm.org/D83177
More information about the llvm-commits
mailing list