[PATCH] D82716: [DAGCombiner] reassociate reciprocal sqrt expression to eliminate FP division

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 6 12:11:04 PDT 2020


spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:13242
+          // Estimate creation failed. Clean up speculatively created nodes.
+          if (AAZ->use_empty())
+            DAG.RemoveDeadNode(AAZ.getNode());
----------------
craig.topper wrote:
> Can we just call recursivelyDeleteUnusedNodes(AAZ) if AAZ is unused and avoid the AA handling?
Yes, that should do the same thing and save a few lines of code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82716/new/

https://reviews.llvm.org/D82716





More information about the llvm-commits mailing list