[PATCH] D83248: [NFCI][IR] Introduce CallBase::Create() wrapper
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 6 12:10:57 PDT 2020
nickdesaulniers added inline comments.
================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1145
+ static CallBase *Create(CallBase *CB, ArrayRef<OperandBundleDef> Bundles,
+ Instruction *InsertPt = nullptr);
+
----------------
No call sites make use of this default value (`nullptr`). Is it the right value? I'm not sure if you can default it to `CB`, but if not, should it just be a required parameter with no default value?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83248/new/
https://reviews.llvm.org/D83248
More information about the llvm-commits
mailing list