[PATCH] D83177: [llvm-reduce] Reducing call operand bundles
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 6 12:06:56 PDT 2020
lebedev.ri added inline comments.
================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1145
+ static CallBase *Create(CallBase *CB, ArrayRef<OperandBundleDef> Bundles,
+ Instruction *InsertPt = nullptr);
+
----------------
nickdesaulniers wrote:
> If we're going to create a new interface to `CallBase`, I kind of want to use it in more than just one place. In particular, at least `InlineFunction()` in `llvm/lib/Transforms/Utils/InlineFunction.cpp` looks like a perfect candidate to use this. There may be more, if you grep for the `cast`s. In that way, this change might help DRY up and also remove a repetitious pattern. WDYT?
Doesn't really sound interesting to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83177/new/
https://reviews.llvm.org/D83177
More information about the llvm-commits
mailing list