[PATCH] D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:633
+vector signed int test_vec_vec_splati_si(void) {
+  // CHECK: ret <4 x i32> <i32 -17, i32 -17, i32 -17, i32 -17>
+  return vec_splati(-17);
----------------
missing CHECK-BE


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:637
+
+vector unsigned int test_vec_vec_splati_ui(void) {
+  // CHECK: ret <4 x i32> <i32 16, i32 16, i32 16, i32 16>
----------------
same


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:643
+vector float test_vec_vec_splati_f(void) {
+  // CHECK: ret <4 x float> <float 1.000000e+00, float 1.000000e+00, float 1.000000e+00, float 1.000000e+00>
+  return vec_splati(1.0f);
----------------
same


================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:651
+  // CHECK-NEXT: [[T3:%.+]] = shufflevector <2 x double> [[T2:%.+]], <2 x double> undef, <2 x i32> zeroinitialize
+  // CHECK-NEXT: ret <2 x double> [[T3:%.+]]
+  return vec_splatid(1.0);
----------------
biplmish wrote:
> lei wrote:
> > missing CHECK-BE?
> There will 1 less case for BE as one splat location will be the same as index.
not sure what you mean.  There is not checks for BE here at all....


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82520/new/

https://reviews.llvm.org/D82520