[PATCH] D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstructionSelector.cpp:39
+  bool select(MachineInstr &I) override;
+  static const char *getName() { return DEBUG_TYPE; }
+
----------------
kbarton wrote:
> arsenm wrote:
> > I'm pretty sure you don't need these and all the other places that override this are dead code
> I don't follow this. 
> Both select and getName seem to be required - getName is needed by the base InstructionSelector implementation in GlobalISel; select is needed by the PPCGenGlobalISel.inc file generated below.
> 
> It is entirely possible I'm doing something incorrect though. Could you explain some more?
Oh right, this isn't the direct pass. I think manual getName overrides are dead code on passes and set by the INITIALIZE_PASS* macros


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83100/new/

https://reviews.llvm.org/D83100