[PATCH] D83175: [X86] Fix a bug that when lowering byval argument
LiuChen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 5 18:07:58 PDT 2020
LiuChen3 marked an inline comment as done.
LiuChen3 added inline comments.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:4045
isByVal = false;
+ hasCopy = true;
} else {
----------------
craig.topper wrote:
> Why do we need a new variable? Can we just pass isByVal to the function?
Yes, we can. I thought it will reduce readability, so I add a new variable.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83175/new/
https://reviews.llvm.org/D83175
More information about the llvm-commits
mailing list