[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

Sun Jul 5 17:35:53 PDT 2020

hoyFB added a comment.

Thanks for the quick turnaround! I confirm the change fixes our build break.

================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:313
   {                                                                            \
     SmallVector<Type *, 8> ArgsTypes({__VA_ARGS__});                           \
     Function *F = M.getFunction(_Name);                                        \
----------------
sstefan1 wrote:
> I wasn't sure how to handle `__VA_ARGS__` here, since we would need `OMPBuilder` in front of every type. 
> That is why helper macros above exist. The problem with this is that this creates some unused variables in `OpenMPOpt`.
> 
> Not sure if `-Wno-unused-variable` would be a good thing to do temporarily? Is there another way to handle `__VA_ARGS__` here?
Could it be possible to use `OMPBuilder. _Name`, `OMPBuilder. _ReturnType` everywhere?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83176/new/

https://reviews.llvm.org/D83176