[PATCH] D83002: [llvm-libtool-darwin] Add support for -static option

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 8 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:100
   InitLLVM X(Argc, Argv);
+  ToolName = Argv[0];
   cl::ParseCommandLineOptions(Argc, Argv, "llvm-libtool\n");
----------------
jhenderson wrote:
> What is `ToolName` used for?
Nothing anymore. Previously, it was being used for the error message. I have removed it now


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:107
+      WithColor::defaultErrorHandler(std::move(E));
+      return 1;
+    }
----------------
jhenderson wrote:
> `return EXIT_FAILURE` maybe? What do other tools typically do?
`llvm-objcopy` does `return 1`. However, `llvm-lipo` does `exit(EXIT_FAILURE)` whereas some other tools (`llvm-ar`, `llvm-as`) use `exit(1)`. I have replaced it with `exit(EXIT_FAILURE)` for now. Is it ok? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83002/new/

https://reviews.llvm.org/D83002