[PATCH] D83167: [argprom] Assessing impact of number of arguments promoted on compiler performance

[Shiva Badruswamy via Phabricator via llvm-commits]

teamiceberg created this revision.
teamiceberg added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
teamiceberg abandoned this revision.
teamiceberg added a comment.

Want to put in a different baseline


Our initial hypothesis is that changes to the magic value of max_elements in argumentpromotion.cpp file can
lead to changes in compiler performance. To assess such changes, we have to introduce a global variable in the argumentpromotion.h header file. Then, we supply different values for this global variable by having a command line flag (-numargspromoted) bound to this global variable via the cl::opt interface. Initial analysis of compiler performance using the built in test suite demonstrate some significant changes in compile time as well as run time. 
However, we are in the process of validating if these changes are real or just noise induced by other means. More experiments and sample runs need to be run, to be sure. However, we are setting up this initial patch as a way to learn how to setup a pipeline to enable the use of global variables to simulate magic values. Also, we are designing LIT tests to ensure that we submit a patch that conforms to built-in argument promotion tests in llvm/test folder.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83167

Files:
  .gitignore
  llvm/include/llvm/Transforms/IPO/ArgumentPromotion.h
  llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
  llvm/test/Transforms/ArgumentPromotion/magic-values/basictest.ll
  llvm/test/Transforms/ArgumentPromotion/magic-values/lit.local.cfg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83167.275532.patch
Type: text/x-patch
Size: 4279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200705/bf98ca2d/attachment.bin>