[PATCH] D83131: [llvm-readobj] - Refine the error reporting in LLVMStyle<ELFT>::printELFLinkerOptions.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 4 11:49:23 PDT 2020
MaskRay added a comment.
> 2. replace reportWarning with reportUniqueWarning calls. In this method it is no-op, because it is not possible to have a duplicated warnings anyways, but since we probably want to switch to reportUniqueWarning globally, this is a good thing to do.
My understanding of the inline comments in D69671 <https://reviews.llvm.org/D69671> is that we will change `reportWarning` call sites to use `reportUniqueWarning` and then rename `reportUniqueWarning` to `reportWarning`. Is that the case?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83131/new/
https://reviews.llvm.org/D83131
More information about the llvm-commits
mailing list