[PATCH] D83139: [InstCombine] Always try to invert non-canonical predicate of an icmp

Sat Jul 4 04:49:39 PDT 2020

lebedev.ri added a comment.

In D83139#2131285 <https://reviews.llvm.org/D83139#2131285>, @nikic wrote:

> > fcmp is a can of worms i'm not inclined to touch here..
>
> Did you run into some particular issue on that front?

We already have conflicting transforms there.
We consider ordered fp predicates to be non-canonical, but at the same time we canonicalize to ordered fp predicate if it's a icmp driving select.
And if we consider ordered to be canonical, then `minnum` (i think?) intrinsic recognition fails.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83139/new/

https://reviews.llvm.org/D83139