[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

Fri Jul 3 23:24:36 PDT 2020

biplmish marked an inline comment as done.
biplmish added inline comments.

================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:12
+// RUN:   -target-cpu pwr10 -triple powerpc64le-unknown-unknown -emit-llvm %s \
+// RUN:   -o - | FileCheck %s -check-prefix=CHECK-LE
+
----------------
lei wrote:
> I just noticed this.  There is no need to add this RUN line since it's the same as the one on line 2.  Please post a patch to remove this and update tests to use the default `CHECK`.
Sure. However there are also tests in Line 125,133 etc which would need modification.

Can we also do "RUN:   -o - | FileCheck %s -check-prefixes=CHECK,CHECK-LE" in the test1 and remove the test3 so that the tests work in the current format.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82365/new/

https://reviews.llvm.org/D82365