[PATCH] D82481: [XCOFF][AIX] Give symbol an internal name when desired symbol name contains invalid character(s)

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 3 21:47:04 PDT 2020


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with minor nit; thanks.



================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:851
+  for (char C : Rename) {
+    // To escape double quote character, the chacacter should be doubled.
+    if (C == DQ)
----------------
Add "a" before "double quote".
s/chacacter/character/;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82481/new/

https://reviews.llvm.org/D82481





More information about the llvm-commits mailing list