[PATCH] D82892: Added comparision for all types in haveSameSpecialState() of Instruction.cpp

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: llvm/lib/IR/Instruction.cpp:416
+  switch (I1->getOpcode()) {
+  default:
+    llvm_unreachable("Instructions to compare are unknown");
----------------
Good idea. this should ensure that any new added instruction will fail compilation unless an entry is added to this switch statement. Maybe we should put a comment here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82892/new/

https://reviews.llvm.org/D82892