[PATCH] D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure
Madhur Amilkanthwar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 3 10:12:42 PDT 2020
madhur13490 added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCCallLowering.cpp:42
+
+ if (VRegs.empty())
+ return true;
----------------
Why not do "return VRegs.empty()"? You can add a comment if it needs readability.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstructionSelector.cpp:23
+
+#define DEBUG_TYPE "ppc-isel"
+
----------------
May be ppc-gisel better?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83100/new/
https://reviews.llvm.org/D83100
More information about the llvm-commits
mailing list