[PATCH] D82444: [SLP] Make sure instructions are ordered when computing spill cost.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 3 05:21:27 PDT 2020


nikic added a comment.

> This seems to have limited practical impact, .e.g on X86 with a recent
>  Intel Xeon CPU with -O3 -march=native -flto on MultiSource,SPEC2000,SPEC2006
>  there are no binary changes.

That's not particularly surprising, as the spill cost is always zero on X86. AArch64 is the only architecture that defines `getCostOfKeepingLiveOverCall()`.

I had a different patch for this issue in D64523 <https://reviews.llvm.org/D64523>, but your solution to the problem is much simpler :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82444/new/

https://reviews.llvm.org/D82444





More information about the llvm-commits mailing list