[PATCH] D82935: [llvm-objcopy] Fix crash when removing symbol table at same time as adding a symbol

[Georgy Komarov via Phabricator via llvm-commits]

jubnzv marked an inline comment as not done.
jubnzv added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/add-symbol-new-symtab.test:44
+# CHECK-NEXT: [ 3] .shstrtab
+# CHECK-NEXT: [ 4] .symtab   {{.+}} {{.+}} {{.+}} {{.+}} {{.+}}      3  {{.+}}
+
----------------
jhenderson wrote:
> Since this is a new section, I'd check the values are all correct, rather than skipping them. Don't forget the alignment column!
I agree. I think it will be more readable if I add values for the other columns as well.
The other tests for llvm-objcopy are written in the same way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82935/new/

https://reviews.llvm.org/D82935