[PATCH] D83094: Analysis: Add a GenericCycleInfo analysis

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

I'll have to leave the implementation review to analysis specialists, but I noticed a few minors.



================
Comment at: llvm/include/llvm/Analysis/CycleInfo.h:19
+#include "llvm/IR/BasicBlock.h"
+#include "llvm/IR/Dominators.h"
+#include "llvm/IR/PassManager.h"
----------------
Do you need to include BasicBlock + Dominators? Can you use forward declarations instead?


================
Comment at: llvm/include/llvm/Analysis/GenericCycleInfo.h:129
+#include "llvm/Support/GenericDomTree.h"
+#include "llvm/Support/Printable.h"
+
----------------
Do you need to include all these? Can you use forward declarations got any instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83094/new/

https://reviews.llvm.org/D83094