[PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 3 01:35:27 PDT 2020


labath added a comment.

What would you say if, instead of `AbbrevTableIndex`, we had a field like `AbbrevTableID`. The main difference would be that this "ID" field can be explicitly specified on the Abbrev table, and it does not have to be a sequentially increasing number (though it could of course be that by default).

The thing I'm trying to achieve is to make the yaml more robust against modifications/simplifications. E.g., it would be nice if deleting an abbrev table does not make all compile units suddenly refer to different tables.  If the ids were present explicitly, compile units would be unaffected by this, and one would get an explicit error message if there was a compile unit left which still referred to the deleted abbrev table.

(This is one of the aspects where an assembler is better than yaml, as symbolic labels in asm have these properties.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83116/new/

https://reviews.llvm.org/D83116





More information about the llvm-commits mailing list