[PATCH] D81929: [WIP][Attributor] Introduce CallBaseContext to the IRPosition

Kuter Dinel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 2 21:03:33 PDT 2020


kuter added a comment.

Btw this patch introduces 8 bytes per attribute because of the `CBContext`.
I think we would ideally move it to a map inside the attributor.

I can inject the context through the update method or make the attribute ask the `Attributor`
like `A.getCBContext(this);` one problem with it is that since  the `operator<<` for `IRPosition` don't have access
to the attributor we would not be able to print it even though it is useful to  have.

One potential solution to this is to use a macro switch to have the `CBContext` inside the `IRPosition` only in debug builds.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81929/new/

https://reviews.llvm.org/D81929





More information about the llvm-commits mailing list